Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-level use statements are sometimes deleted when rearraged. #3609

Closed
dr-bonez opened this issue Jun 7, 2019 · 1 comment
Closed

top-level use statements are sometimes deleted when rearraged. #3609

dr-bonez opened this issue Jun 7, 2019 · 1 comment

Comments

@dr-bonez
Copy link

dr-bonez commented Jun 7, 2019

Tested in VSCode with latest rls and Format on Save:

use crate::stuff;
use failure::Error;
use r2d2::ConnectionManager;
use diesel::PgConnection;

becomes

use crate::stuff;
use diesel::PgConnection;
use r2d2::ConnectionManager;

This deleted an import.
I have observed this behavior consistently on any set of mis-ordered imports.

@topecongiro topecongiro added bug Panic, non-idempotency, invalid code, etc. a-imports `use` syntax p-high and removed a-imports `use` syntax bug Panic, non-idempotency, invalid code, etc. p-high labels Jun 7, 2019
@topecongiro
Copy link
Contributor

Couldn't reproduce this locally. This is probably due to a bug in VSCode extension. cc rust-lang/vscode-rust#595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants