Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"missing installed component" error should be translated through renames #2440

Closed
joshtriplett opened this issue Jul 25, 2020 · 8 comments · Fixed by #2554
Closed

"missing installed component" error should be translated through renames #2440

joshtriplett opened this issue Jul 25, 2020 · 8 comments · Fixed by #2554

Comments

@joshtriplett
Copy link
Member

As documented, component names passed to rustup component add are translated through the renames table, and component names in rustup component list are translated backwards through renames. However, when rustup skips a nightly version because it doesn't have an installed component, the error message gives the "preview" component name, and doesn't translate backwards through renames:

info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2020-07-25, rust version 1.47.0-nightly (5ef299eb9 2020-07-24)
info: skipping nightly which is missing installed component 'rustfmt-preview'
info: syncing channel updates for 'nightly-2020-07-24-x86_64-unknown-linux-gnu'
info: latest update on 2020-07-24, rust version 1.47.0-nightly (0820e54a8 2020-07-23)
info: skipping nightly which is missing installed component 'rustfmt-preview'

rustup --version: rustup 1.22.1 (b01adbbc3 2020-07-08)
rustup show:

Default host: x86_64-unknown-linux-gnu
rustup home:  /home/josh/.rustup

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu (default)
nightly-x86_64-unknown-linux-gnu
system

installed targets for active toolchain
--------------------------------------

wasm32-wasi
x86_64-unknown-linux-gnu

active toolchain
----------------

stable-x86_64-unknown-linux-gnu (default)
rustc 1.45.0 (5c1f21c3b 2020-07-13)

@kinnison
Copy link
Contributor

Well spotted. This should definitely be fixed otherwise users may get confused.

@kinnison
Copy link
Contributor

This ought to be fairly straightforward to correct. I'd be happy to discuss it either here or on Discord with anyone interested in attempting a fix.

@rbtcollins
Copy link
Contributor

We should probably fix the stringification stuff for these types so that it is fixed systematically.

@kinnison
Copy link
Contributor

We should probably fix the stringification stuff for these types so that it is fixed systematically.

IIRC the component doesn't have back-references to its manifest which is needed for renaming.

@salpalvv

This comment has been minimized.

@kinnison

This comment has been minimized.

@salpalvv

This comment has been minimized.

@rbtcollins
Copy link
Contributor

rbtcollins commented Aug 19, 2020

This bug describes how the message that is output should be translated to deal with the metadata in the publication process that deal with publishing it on the web.

Your question/error is something to do with the installation process, and entirely unrelated to this bug, other than that the same message which is being discussed is output in both cases.

Please follow the request and open a new ticket, it was made in good faith.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants