Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete simple-ci GitHub Action #445

Closed
3 tasks done
MarcoIeni opened this issue Jul 17, 2024 · 0 comments · Fixed by #459
Closed
3 tasks done

Delete simple-ci GitHub Action #445

MarcoIeni opened this issue Jul 17, 2024 · 0 comments · Fixed by #459
Assignees

Comments

@MarcoIeni
Copy link
Member

MarcoIeni commented Jul 17, 2024

As discussed in Delete simple-ci GitHub Action Zulip stream, we want to remove the simple-ci GitHub Action for the following reasons:

  • The action uses node 16 which reached end of life and we don't want to spend time maintaining this action in the future
  • As stated in the GitHub Actions readme the action was "supposed to only be used in infra managed by us", but the infra team is not using this action anywhere
  • This GitHub search shows that the action is only used in 15 files in GitHub, most of which are markdown files or belong to forks. We want to delete this action to avoid that more repositories adopt it.

Migration guide

Substitute

- uses: rust-lang/simpleinfra/github-actions/simple-ci@master

with

# if checkFmt was true
- name: Install rustfmt
  run: rustup component add rustfmt
- name: Check formatting
  run: cargo fmt --all --check

- name: Build
  run: cargo build --tests --workspace
- name: Test
  run: cargo test --workspace

Plan

I will raise PRs on all the repositories using this action, according to this GitHub search:

The repos with a checkbox are projects we don't want to break. So we want to wait for them to merge the PR before deleting this action. The other projects are just templates or examples, so we can delete the action even if they didn't merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant