Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiate query response nested obligations #21

Closed
lcnr opened this issue May 26, 2023 · 2 comments
Closed

instantiate query response nested obligations #21

lcnr opened this issue May 26, 2023 · 2 comments

Comments

@lcnr
Copy link
Contributor

lcnr commented May 26, 2023

While instantiating a query response we may end up emitting nested obligations.

This is annoying and we have to deal with them somehow. We currently put them into the fulfillment context of the caller, but that may not be great for diagnostics. I think we could alternatively loop tem in a separate context while instantiating and OR their certainty with the main goal

@compiler-errors
Copy link
Member

For coherence: we already do this in evaluate_predicate so it's not unsound at least :^).

@lcnr
Copy link
Contributor Author

lcnr commented Mar 14, 2024

with rust-lang/rust#119106 instantiating query responses does not result in nested obligations anymore. Closing

@lcnr lcnr closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants