Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACPI: from_tables_direct has been removed #172

Closed
rw-vanc opened this issue Mar 31, 2023 · 4 comments
Closed

ACPI: from_tables_direct has been removed #172

rw-vanc opened this issue Mar 31, 2023 · 4 comments

Comments

@rw-vanc
Copy link
Contributor

rw-vanc commented Mar 31, 2023

What is the recommended alternative to acpi::AcpiTables::from_tables_direct, which has been removed? My ideal would be to pass in the tables without a handler to map the table data, but I'm not sure how much you need to access tables using physical addresses.

I'm happy to implement whatever you think the best solution is.

@rw-van
Copy link

rw-van commented Apr 26, 2023

From Isaac:

So from_tables_direct was removed when we moved away from pre-processing all of the tables into a container, and isn't easily re-added unfortunately. However, we should still be able to use all the types (only the new functions tend to be parameterized over the Handler, so we could provide a new way to construct tables without a handler fairly easily I think, depending on what exactly you want on your end

@rw-van
Copy link

rw-van commented Apr 26, 2023

Just to be clear, the proposed solution is to change parameterized types for the various tables to not be parameterized, but to leave a parameterized new function that takes a Handler, and a different non-parameterized version that is created from contiguous table data possibly in virtual memory. This will be a breaking change due to the removal of the type parameter.

@onkoe
Copy link

onkoe commented Nov 2, 2024

from_tables_direct is still mentioned in the acpi crate's module documentation.

@IsaacWoods
Copy link
Member

from_tables_direct is still mentioned in the acpi crate's module documentation.

Thanks for reporting, I've removed the reference to this method from the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants