Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rand_distr to new repository #1394

Open
dhardy opened this issue Feb 13, 2024 · 1 comment
Open

Move rand_distr to new repository #1394

dhardy opened this issue Feb 13, 2024 · 1 comment

Comments

@dhardy
Copy link
Member

dhardy commented Feb 13, 2024

Motivation

rand_distr depends on rand, but nothing else here depends on rand_distr. Although rand_distr must reflect changes in rand::distributions (or rand::distr - #1381), it is a mistake to co-version these code-bases: a few breaking changes to rand are the only thing preventing us from making a new release of rand_distr (overdue).

There is some motivation for co-versioning the other crates in this repository: rand_core, rand_chacha, rand_pcg and rand all have inter-dependencies. The same is not true for rand_distr.

Further, it is usually very clear whether an issue relates to rand_distr or other parts of rand.

Plan

There are two obvious approaches:

  1. Copy rand_distr code to a new repo. Adjust the rand dependency to the last released version, reverting a few breaking changes (Uniform::new returning a Result, ...?). Plan the next release.
  2. Wait until the next stable rand release (slightly less work).
@benjamin-lieser
Copy link
Collaborator

I agree that there is no good reason to co-version rand_distr and I think it is fine to wait until the next stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants