Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dirichlet distribution #400

Closed
rohitjoshi opened this issue Apr 16, 2018 · 5 comments
Closed

Support for Dirichlet distribution #400

rohitjoshi opened this issue Apr 16, 2018 · 5 comments
Labels
E-help-wanted Participation: help wanted F-new-int Functionality: new, within Rand P-low Priority: Low

Comments

@rohitjoshi
Copy link

It would be helpful if we can add support for Dirichlet distribution. I am currently using crate statrs for Dirichlet and rand for another type of distribution.

Here is numpy implementation: https://github.com/numpy/numpy/blob/master/numpy/random/mtrand/mtrand.pyx#L4723

@dhardy
Copy link
Member

dhardy commented Apr 16, 2018

Good call, but also see #290.

In any case, adding new distributions is not a focus right now, but PRs will be considered.

@dhardy dhardy added F-new-int Functionality: new, within Rand T-distributions P-low Priority: Low E-help-wanted Participation: help wanted labels Apr 16, 2018
@pitdicker
Copy link
Contributor

@rohitjoshi Would you be interested in making a PR?

@rohitjoshi
Copy link
Author

Sure, I implemented in my project. Will submit a PR.

@pitdicker
Copy link
Contributor

Now that Rand 0.5 is out the door, can I give you a small reminder? No obligations of course.

@rohitjoshi
Copy link
Author

@pitdicker will submit PR this weekend. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Participation: help wanted F-new-int Functionality: new, within Rand P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants