Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add request_interrupt_window handling #193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

QuarkContainer
Copy link

No description provided.

Copy link
Collaborator

@lauralt lauralt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you also please sign off your commit (git commit -s --amend)?

Comment on lines +1437 to +1438


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are unintentional.

@@ -1403,6 +1403,12 @@ impl VcpuFd {
kvm_run.immediate_exit = val;
}

/// Sets the `request_interrupt_window` flag on the `kvm_run` struct associated with this vCPU to `val`.
pub fn set_kvm_request_interrupt_window(&self, val: u8) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for this, it can be similar to the one for set_kvm_immediate_exit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants