vcpu: Fix Arm target_arch gate for set_guest_debug #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrXinWang
requested review from
acatangiu,
alxiord,
andreeaflorescu,
lauralt and
sameo
as code owners
|
/cc @michael2012z |
MrXinWang
force-pushed
the
fix_set_guest_debug_gate
branch
from
32b82f9
to
4d2e24f
Compare
liuw
reviewed
Jun 28, 2022
MrXinWang
force-pushed
the
fix_set_guest_debug_gate
branch
from
4d2e24f
to
adf6832
Compare
|
Hi @andreeaflorescu @lauralt, any comments for this one? To add a little bit more context, we found this issue when trying to enable the GDB debuggability for the guest VM. |
andreeaflorescu
previously approved these changes
Jul 4, 2022
lauralt
previously approved these changes
Jul 4, 2022
MrXinWang
dismissed stale reviews from lauralt, andreeaflorescu, and liuw
via
18e740c
MrXinWang
force-pushed
the
fix_set_guest_debug_gate
branch
from
adf6832
to
18e740c
Compare
KVM_SET_GUEST_DEBUG supports arm64 architecture, but the correct target_arch gate name in Rust should be aarch64 instead of arm64. This commit does the fix for set_guest_debug() so that other crates that depend on the kvm-ioctls crate can be benefited. Signed-off-by: Henry Wang <[email protected]>
MrXinWang
force-pushed
the
fix_set_guest_debug_gate
branch
from
6af0cbd
to
98187ba
Compare
lauralt
approved these changes
Jul 4, 2022
andreeaflorescu
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
KVM_SET_GUEST_DEBUG supports arm64 architecture, but the correct
target_arch gate name in Rust should be aarch64 instead of arm64.
This commit does the fix for set_guest_debug() so that other
crates that depend on the kvm-ioctls crate can be benefited.
Signed-off-by: Henry Wang [email protected]
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafecode is properly documented.