feat(aarch64): generic get/set_one_reg #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
requested review from
acatangiu,
alxiord,
andreeaflorescu,
lauralt and
sameo
as code owners
roypat
requested changes
May 16, 2023
ShadowCurse
force-pushed
the
generic_arm
branch
6 times, most recently
from
941756d
to
c866df4
Compare
roypat
previously approved these changes
May 18, 2023
There was a problem hiding this comment.
To me this looks future proof and safe, meaning we won't run into weird issues with too-wide ARM registers again.
It should definitely get a CHANGELOG entry, since its a breaking change, though. Also, I'm not 100% sure the to_le_bytes in the tests work for big endian architectures that rust-vmm formally supports. Someone with more experience there should give that a look over.
Linux kernel defines arm registers up to 2048 bits wide. To support all different sized registers we change get/set_one_reg methods to accept a byte slice. For `set_one_reg` slice contains register data to be written to vcpu. For `get_one_reg` slice will have register data read from vcpu. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
dismissed stale reviews from roypat and JonathanWoollett-Light
via
5bbd85b
Signed-off-by: Egor Lazarchuk <[email protected]>
andreeaflorescu
approved these changes
May 22, 2023
alxiord
approved these changes
May 22, 2023
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this pull request
Jan 24, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: cloud-hypervisor#6072 Signed-off-by: Bo Chen <[email protected]>
rbradford
pushed a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this pull request
Jan 25, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: #6072 Signed-off-by: Bo Chen <[email protected]>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this pull request
Mar 5, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: cloud-hypervisor#6072 Signed-off-by: Bo Chen <[email protected]> (cherry picked from commit 3ce0fef)
github-merge-queue bot
pushed a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this pull request
Mar 14, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: #6072 Signed-off-by: Bo Chen <[email protected]> (cherry picked from commit 3ce0fef)
github-merge-queue bot
pushed a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this pull request
Mar 14, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: #6072 Signed-off-by: Bo Chen <[email protected]> (cherry picked from commit 3ce0fef)
github-merge-queue bot
pushed a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this pull request
Mar 14, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: #6072 Signed-off-by: Bo Chen <[email protected]> (cherry picked from commit 3ce0fef)
likebreath
added a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this pull request
Mar 15, 2024
This patch bumps the following crates, including `[email protected]`*, `[email protected]`**, `[email protected]`, `[email protected]`, `[email protected]`***, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and the latest of `vfio-bindings`, `vfio-ioctls`, `mshv-bindings`,`mshv-ioctls`, and `vfio-user`. * A fork of the `kvm-bindings` crate is being used to support serialization of various structs for migration [1]. Also, code changes are made to accommodate the updated `struct xsave` from the Linux kernel. Note: these changes related to `struct xsave` break live-upgrade. ** The new `kvm-ioctls` crate introduced breaking changes for the `get/set_one_reg` API on `aarch64` [2], so code changes are made to the new APIs. *** A fork of the `versionize_derive` crate is being used to support versionize on packed structs [3]. [1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0 [2] rust-vmm/kvm#223 [3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6 Fixes: #6072 Signed-off-by: Bo Chen <[email protected]> (cherry picked from commit 3ce0fef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Linux kernel defines arm registers up to 2048 bits wide. To support all different sized the PR changes
get/set_one_regmethods to accept a byte slice that either contains register data or will have register data be written to.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.