cap: add KvmCapStealTime capability #239
Conversation
xuejun-xj
requested review from
acatangiu,
alxiord,
andreeaflorescu,
lauralt,
sameo,
roypat and
JonathanWoollett-Light
as code owners
xuejun-xj
force-pushed
the
xuejun/pvtime
branch
from
13fdeeb
to
645fe6f
Compare
There was a problem hiding this comment.
Do you think there's value in adding testing similar to https://github.com/bchalios/kvm-ioctls/blob/0177432e14e697db0d88a1dd753179d639b9e4c2/src/ioctls/vcpu.rs#L2789-L2806?
CHANGELOG.md
Outdated
| - [[#239](https://github.com/rust-vmm/kvm-ioctls/pull/239)] cap: add KvmCapStealTime | ||
| capability. |
There was a problem hiding this comment.
nit: In 0.15.0 we phrase capability addition as "Add Cap::KvmCapStealTime capability". Could we keep these consistent? :o
There was a problem hiding this comment.
Ok, thanks. I will fix later.
This capability is used for kvm steal time feature. Signed-off-by: xuejun-xj <[email protected]>
xuejun-xj
force-pushed
the
xuejun/pvtime
branch
from
645fe6f
to
de24816
Compare
Hi @roypat! Thanks for the reminder. I have add a test case(test_kvm_steal_time_capability) for aarch64. Is there anyone can help me to add test case for x86_64? According to the docs, it may be initialized with another path on x86_64. |
This capability is used for kvm steal time feature.
Docs for KVM_CAP_STEAL_TIME