aarch64: Reorganize test_create_device
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimePrinciple
requested review from
acatangiu,
andreeaflorescu,
lauralt,
sameo,
roypat and
ShadowCurse
as code owners
TimePrinciple
force-pushed
the
repurpose-arm-device-tests
branch
from
dcdb3a1
to
39797fe
Compare
roypat
reviewed
Sep 30, 2024
TimePrinciple
force-pushed
the
repurpose-arm-device-tests
branch
from
9af27d5
to
7c919c6
Compare
Add `has_device_attr` check in both `set_supported_nr_irqs` and `request_gic_init`, effectively enabling reuse of `request_gic_init` in `test_create_device`. Signed-off-by: Ruoqing He <[email protected]>
As @roypat pointed out, and quote: "Asserting on .is_ok()/.is_err() leads to hard to debug failures (as if the test fails, it will only say "assertion failed: false". We replace these with `.unwrap()`, which also prints the exact error variant that was unexpectedly encountered (we can to this these days thanks to efforts to implement Display and Debug for our error types). If the assert!((...).is_ok()) was followed by an .unwrap() anyway, we just drop the assert." Signed-off-by: Ruoqing He <[email protected]>
TimePrinciple
force-pushed
the
repurpose-arm-device-tests
branch
from
7c919c6
to
b768e08
Compare
roypat
reviewed
Sep 30, 2024
As @roypat pointed out, and quote: "This lint disallows asserttions on is_ok()/is_err() in favor of either using unwrap (so that at least if the test fails, we the failure message will contain the actual failure reason instead of just "was not ok/err"), or actually matching the specific variant." Signed-off-by: Ruoqing He <[email protected]>
TimePrinciple
force-pushed
the
repurpose-arm-device-tests
branch
from
b768e08
to
fad90be
Compare
roypat
approved these changes
Sep 30, 2024
rbradford
approved these changes
Sep 30, 2024
If you like, I will do it in cloud-hypervisor :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Add
has_device_attrcheck in bothset_supported_nr_irqsandrequest_gic_init, effectively enabling reuse ofrequest_gic_initintest_create_device.I was going through these tests while introducing RISC-V ioctls. Some minor improvements :)
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.