Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not look for .git or .git/info/exclude if git-ignore = false #1261

Open
tfar opened this issue Sep 26, 2024 · 1 comment
Open

Should not look for .git or .git/info/exclude if git-ignore = false #1261

tfar opened this issue Sep 26, 2024 · 1 comment
Labels
C-question Category: Further information is requested C-upstream Category: Issue for a dependency, will be fixed upstream

Comments

@tfar
Copy link

tfar commented Sep 26, 2024

I have set git-ignore = false in my config. Yet strace shows tons of the following commands when running a backup:

[pid 2301286] stat("/1/5/e/e/0/.git", 0x7f49ced334a0) = -1 ENOENT (No such file or directory)
[pid 2301286] stat("/1/5/e/e/0/.git/info/exclude", 0x7f49ced331c0) = -1 ENOENT (No such file or directory)
@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Sep 26, 2024
@simonsan
Copy link
Contributor

https://github.com/rustic-rs/rustic_core/blob/main/crates/core/src/backend/ignore.rs#L208-L209

I looked into this, and it seems to be either an upstream issue or intended behaviour, to determine if a subfolder is a git repo.

@simonsan simonsan added C-question Category: Further information is requested C-upstream Category: Issue for a dependency, will be fixed upstream and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-question Category: Further information is requested C-upstream Category: Issue for a dependency, will be fixed upstream
Projects
None yet
Development

No branches or pull requests

2 participants