Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of typing string values more tightly #29

Open
daboross opened this issue Sep 9, 2018 · 1 comment
Open

Possibility of typing string values more tightly #29

daboross opened this issue Sep 9, 2018 · 1 comment
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.

Comments

@daboross
Copy link
Collaborator

daboross commented Sep 9, 2018

Right now, methods like owner_name and id return strings. We could be strictly more accurate and return wrappers around String, like Username and ObjectId.

My main reasoning not to do this is that it'll all be serialized and deserialized in between ticks anyways, but that's not a very strong argument.

@daboross daboross added the C-enhancement Category: A PR with an enhancement or a proposed on in an issue. label Sep 9, 2018
@ASalvail
Copy link
Collaborator

Partially addressed by #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Projects
None yet
Development

No branches or pull requests

2 participants