Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up Overhaul #179

Open
birdddev opened this issue Feb 28, 2024 · 2 comments
Open

Pop-up Overhaul #179

birdddev opened this issue Feb 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@birdddev
Copy link
Collaborator

birdddev commented Feb 28, 2024

RevealUI (FavBar draft/app icons, requirements/tooltips) and Menus (combos/dropdowns, search enum) should re-use an underlying PopUp widget.
This should keep logic and visual consistency between them, similar to how InputBoolUI is used in place of check-boxes now.

<PopUp></PopUp>

  • Should prevent itself from having any part of the pop-up go off-screen
  • Close based on distance outside of pop-up and on-click outside of pop-up (Clicking outside a pop-up should probably prevent event propagation)
@birdddev birdddev added the enhancement New feature or request label Feb 28, 2024
@birdddev birdddev self-assigned this Feb 28, 2024
@rvion
Copy link
Owner

rvion commented Feb 28, 2024

Combos/dropdowns are also using RevealUI
and I was planning to make selectUI also use it;
I want to polish RevealUI widget quite a lot, cause it's going to be a key component; really want to get it right;
I was among other things planning to handling nested Reveal Properly too via react context and push/pop within a single root reveal state

@birdddev
Copy link
Collaborator Author

birdddev commented Feb 28, 2024

Should I rename <RevealUI> to <PopUp>/<PopUpUI> and then work from there?
Making SelectUI use it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo Next
Development

No branches or pull requests

2 participants