Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple txt2img workflow fails to parse #70

Open
oxysoft opened this issue Nov 10, 2023 · 9 comments
Open

Simple txt2img workflow fails to parse #70

oxysoft opened this issue Nov 10, 2023 · 9 comments
Labels
bug Something isn't working prio 1 (ASAP)

Comments

@oxysoft
Copy link

oxysoft commented Nov 10, 2023

hamburger.json

Please see the attached hamburger workflow.

Cannot read properties of undefined (reading 'input')

Works totally fine in ComfyUI

@rvion rvion added the bug Something isn't working label Nov 10, 2023
@rvion
Copy link
Owner

rvion commented Nov 10, 2023

want to join today's stream on https://discord.gg/GfAN6hF2ad ?
I'm going to fix this one live right now

@rvion
Copy link
Owner

rvion commented Nov 10, 2023

Can't seem to find your lcm-optimizer-sd15.safetensors on the net.
any link to share (didn't found the file from https://latent-consistency-models.github.io/ )

without it, not quite sure I'm debugging the right thing because of this error
image

@oxysoft
Copy link
Author

oxysoft commented Nov 11, 2023

These weights https://huggingface.co/latent-consistency/lcm-lora-sdv1-5/blob/main/pytorch_lora_weights.safetensors I think you can just put in any LoRA tho, the output won't look right but that's fine for this repro

@oxysoft
Copy link
Author

oxysoft commented Nov 11, 2023

Yeah so actually I think literally every single image I ever rendered in ComfyUI doesn't open in CushyStudio with this same bug, so this is critical to figure out. Here is a simplified burger to help you

burger.json

@rvion
Copy link
Owner

rvion commented Nov 11, 2023

Thanks ! I'll check this one out tomorrow

@rvion
Copy link
Owner

rvion commented Nov 12, 2023

image

I think I'm onto something 🤣

@rvion
Copy link
Owner

rvion commented Nov 12, 2023

I guess I just have to prioritize adding validation everywhere so I don't send time debugging things anymore, and just wait for people to send me nice screenshots of what error message they see 🙃

@oxysoft
Copy link
Author

oxysoft commented Nov 12, 2023

Haha yes indeed, game development taught me you can never have too much printing. I didn't like that error message very much myself, you should know exactly which node crashed it, or if it was outside of that, etc.

@rvion
Copy link
Owner

rvion commented Nov 12, 2023

@oxysoft

honestly, I have no idea if I have fixed your issue or not, your burger.json never ran on my end.
Your "random prompt" node simply don't work on my ComfyUI install, with everything up-to-date.

Can you update your nodes and send me some other example with both Comfy and your node pack up to date ?

image

when I replace this node by a text primitive, it works.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio 1 (ASAP)
Projects
None yet
Development

No branches or pull requests

2 participants