Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in generated types: Reserved type number in global.ts #84

Open
ricklove opened this issue Nov 29, 2023 · 2 comments
Open

Error in generated types: Reserved type number in global.ts #84

ricklove opened this issue Nov 29, 2023 · 2 comments

Comments

@ricklove
Copy link
Collaborator

Reserved type number in global.ts:

Type alias name cannot be 'number'.
export type number = ComfyNodeOutput<'number'>

image


Nice work though!

@rvion
Copy link
Owner

rvion commented Nov 29, 2023

Nice catch! You have a custom node that I'm not aware of that use 'number' as output type. could you take a look at you object_info.json and tell me what node is causing this ? It Would help me troubleshoot if I could install the node and work from there to preventing the conflict with native typescript types

@ricklove
Copy link
Collaborator Author

I think it is from https://github.com/flyingshutter/As_ComfyUI_CustomNodes:

,    "Number_AS": {
        "input": {
            "required": {
                "value": ["FLOAT",{"default":0,"min":-1.7976931348623157e+308,"max":1.7976931348623157e+308}]
            }
        }
,        "output": ["number"]
,        "output_is_list": [false]
,        "output_name": ["number"]
,        "name": "Number_AS"
,        "display_name": "Number_AS"
,        "description": ""
,        "category": "ASNodes"
,        "output_node": false
    }

https://github.com/flyingshutter/As_ComfyUI_CustomNodes/blob/2476d8579206e9aa64f593ac2ae5c88f6fbee252/asnodes.py#L342C7-L342C7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants