You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're getting a lot of errors in our application coming from the call to target.hasAttribute('data-ember-action') because hasAttribute is not defined. I haven't been able to identify what event is causing it, but it seems like it is likely something where window is the target.
I'll submit a PR if you want to let me know how you want to guard against this. Seems like changing the line to else if (target && target.hasAttribute && target.hasAttribute('data-ember-action')) would work. I'm assuming there is a reason its a do-while loop and not while, otherwise converting to a while loop should also prevent it.
Because this package is deprecated and replaced in Ember 3.0, we are no longer receiving the error from this package; however, it is now being generated by Ember's internals.
I've created an issue in ember.js - emberjs/ember.js#16730
We're getting a lot of errors in our application coming from the call to
target.hasAttribute('data-ember-action')
because hasAttribute is not defined. I haven't been able to identify what event is causing it, but it seems like it is likely something wherewindow
is the target.I'll submit a PR if you want to let me know how you want to guard against this. Seems like changing the line to
else if (target && target.hasAttribute && target.hasAttribute('data-ember-action'))
would work. I'm assuming there is a reason its a do-while loop and not while, otherwise converting to a while loop should also prevent it.The text was updated successfully, but these errors were encountered: