Migrate to using ESM #158
Merged
Migrate to using ESM #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around an issue with node/no-missing-import that doesn't properly see that `node:path` is a valid module on Node 12.x. They are using `is-core-module` to figure out if it is a module or not, and it seems that `is-core-module` doesn't differentiate between core modules that are available for CJS (the `node:` prefixed paths are only available in 14.18+ and 16+ in CJS files) and those that are available to ESM. This is really just a bandaid, the right fix would be to send a PR to is-core-module to allow it to check CJS vs MJS modules (since they are actually different). See mysticatea/eslint-plugin-node#299
rwjblue
force-pushed
the
migrate-to-esm
branch
from
f0acce2
to
a8b3cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.