Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagespeed #33

Open
shabda opened this issue Jul 9, 2014 · 3 comments
Open

Pagespeed #33

shabda opened this issue Jul 9, 2014 · 3 comments

Comments

@shabda
Copy link

shabda commented Jul 9, 2014

Hi,

Adding pagespeed to nginx can make a significant difference to the forntend performance. It can be built from source for nginx:
https://developers.google.com/speed/pagespeed/module/build_ngx_pagespeed_from_source

Would you consider this or consider this outside the scope of this project? I have this working for a site of ours, and can send a PR.

@pcasaretto
Copy link

👍

@ryandotsmith
Copy link
Owner

Looks neat!
If it can be something that is optionally added by the buildback user, then I would accept a PR.

@shabda
Copy link
Author

shabda commented Sep 3, 2014

@ryandotsmith : It needs to be explicitly enabled by user in nginx.comf.erb:
https://github.com/agiliq/agiliq/blob/master/config/nginx.conf.erb#L41

If you don't enable this there is no difference to nginx. However if you want to enable/disable this at buildpack level, you will have to ship two binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants