Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds support to ruby 2.3 #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: ruby
rvm:
- 1.9.2
- 1.9.3
- jruby-19mode
- jruby-9.0.5.0
- 2.1.0
- 2.0.0
- 2.2.5
- 2.3.0
2 changes: 1 addition & 1 deletion redis_failover.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ Gem::Specification.new do |gem|
gem.add_dependency('zk', ['>= 1.7.4', '< 1.8'])

gem.add_development_dependency('rake')
gem.add_development_dependency('rspec')
gem.add_development_dependency('rspec', '~> 3')
gem.add_development_dependency('yard')
end
8 changes: 4 additions & 4 deletions spec/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def setup_zk
called = true
end
client.del('foo')
called.should be_true
called.should be_truthy
end

describe '#inspect' do
Expand Down Expand Up @@ -82,7 +82,7 @@ def setup_zk
called = true
end
client.get('foo')
called.should be_true
called.should be_truthy
end
end

Expand All @@ -94,7 +94,7 @@ def setup_zk
called = true
end
client.get('foo')
called.should be_true
called.should be_truthy
end
end

Expand All @@ -118,7 +118,7 @@ def fetch_nodes

client.current_master.make_unavailable!
client.del('foo')
client.reconnected.should be_true
client.reconnected.should be_truthy
end

context 'with :verify_role true' do
Expand Down
4 changes: 2 additions & 2 deletions spec/util_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ module RedisFailover

describe '.different?' do
it 'handles different arrays' do
Util.different?([1,2,3], [1,5,3]).should be_true
Util.different?([1,2,3], [1,5,3]).should be_truthy
end

it 'handles non-different arrays' do
Util.different?([1,2,3], [3,2,1]).should be_false
Util.different?([1,2,3], [3,2,1]).should be_falsey
end
end
end
Expand Down