Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images don't show in preview mode when editing a page. #289

Open
GrahamDumpleton opened this issue Jan 20, 2019 · 1 comment
Open

Images don't show in preview mode when editing a page. #289

GrahamDumpleton opened this issue Jan 20, 2019 · 1 comment
Assignees
Labels
qa Verify / Quality Assurance

Comments

@GrahamDumpleton
Copy link
Contributor

Need to do more checks on when this occurs, but in some circumstances at least, images are not showing in markdown preview when editing page. For example, in case where so happen to be using at a base_url or /workshop, if URL path is /workshop/index/edit, get:

image

This is because the HTML generated from markdown preview is:

<p><img src="jupyterpreview.png" alt="Jupyter Notebooks" title=""></p>

So the src ref is going to end up trying to load /workshop/index/jupyterpreview.png rather than /workshop/jupyterpreview.png.

Need to have the markdown preview know it has to adjust image paths to add ../ in front, or do something else so they resolve to correct location.

@ryanlelek ryanlelek added the qa Verify / Quality Assurance label Aug 12, 2022
@ryanlelek ryanlelek self-assigned this Aug 12, 2022
@ryanlelek
Copy link
Owner

I believe this is corrected in the latest version.
Will do some QA checks soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Verify / Quality Assurance
Projects
None yet
Development

No branches or pull requests

2 participants