Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octicons scale fail #1288

Closed
237dmitry opened this issue Jun 6, 2023 · 5 comments
Closed

Octicons scale fail #1288

237dmitry opened this issue Jun 6, 2023 · 5 comments

Comments

@237dmitry
Copy link

237dmitry commented Jun 6, 2023

#1240
#1261

Nothing was fixed in 3.0.2. The same issue as in the initial one. The problem is not in circles but in \UE0B4

3.0.0:
300

3.0.1 & 3.0.2:
302

@Finii
Copy link
Collaborator

Finii commented Jun 6, 2023

image

From #1240, I asked you if ea71 is the problematic glyph and you said it is.
But in the top of that issue (I just noticed that) you use f444. That is a completely different set, and I did not look at that, of course.

So please use ea71, THAT is fixed.

@Finii Finii closed this as completed Jun 6, 2023
@Finii
Copy link
Collaborator

Finii commented Jun 6, 2023

Octicons is shifted from F000 to F400.
So F444 is F044 in the icon font.

Why is that in triangles?

image

Ah no, Octicons is packed, so the circle is in fact f052. f044 is a triangle.

image

The circle is in small stuff, lets see what that is

.....

A TYPO

image

The F is missing with F296 😭

@Finii
Copy link
Collaborator

Finii commented Jun 6, 2023

On the update we changed to plus

image

CommitDate: Wed May 3 09:58:23 2023 +0200

    font-patcher: Fix some Octicons scales

    [why]
    With the Octicons update some codepoint contents changed.
    Also some symbols scale still wrong.

    [how]
    Check fonts and add / drop entries.
    Use GlyphsToScale+ to correct position of Github text icon.

    Fixes: #1198

@Finii Finii reopened this Jun 6, 2023
@Finii Finii changed the title # 1240 Nothing was changed Octicons scale fail Jun 6, 2023
@Finii
Copy link
Collaborator

Finii commented Jun 6, 2023

The problem is not in circles but in \UE0B4

Repeating this over and over will not help (and is wrong, as I tried to explain before).

@Finii Finii closed this as completed Nov 11, 2023
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants