Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iosevka Term Slab #281

Closed
aswinmohanme opened this issue Jun 30, 2018 · 19 comments · Fixed by #803
Closed

Add Iosevka Term Slab #281

aswinmohanme opened this issue Jun 30, 2018 · 19 comments · Fixed by #803

Comments

@aswinmohanme
Copy link

It would be nice if you guys could support Iosevka Term Slab Officially, this would complete the Iosevka Family.

@ryanoasis
Copy link
Owner

Great suggestion, thanks

@aswinmohanme
Copy link
Author

Thank you for the awesome fonts :D

@ryanoasis
Copy link
Owner

Thanks! They are already awesome fonts we just patch 'em 😊 and aggregate a bunch of things but I know what you mean 😄

@neo-anderson
Copy link

I think slab version of this font has not been added to the collection. Why was this issue closed?

@mfiano
Copy link

mfiano commented Mar 16, 2021

Can we please get Slab added? Thanks!

@ankitp4t3l
Copy link

ankitp4t3l commented Jun 6, 2021

In case you want the font and don't want to wait, you can use the nerd fonts patching tool as describe in the readme.

Note, the patcher tool does not work for .ttc collections, so you'll want to "extract" the .ttf(s) you are interested in and use the font patching tool on the .ttf(s).

I just did so for the regular fixed slab iosevka and it worked on my env (macOS).

@typkrft
Copy link

typkrft commented Jan 5, 2022

In case you want the font and don't want to wait, you can use the nerd fonts patching tool as describe in the readme.

From my understanding the patcher doesn't work on ARM.

@eggbean
Copy link

eggbean commented Mar 4, 2022

Has anyone nerdified this font which they can share?

@Finii
Copy link
Collaborator

Finii commented Mar 4, 2022

@eggbean Supply links to the exact font files you like to have patched and I can upload them in a branch ;-)

@Finii
Copy link
Collaborator

Finii commented Mar 4, 2022

Note, the patcher tool does not work for .ttc collections

@ankitp4t3l Well, one could use #783 ;-D

@eggbean
Copy link

eggbean commented Mar 4, 2022

@Finii This is the latest version I could find. Thanks.
https://en.fontke.com/font/42051117/download/


EDIT And this one too please. https://en.fontke.com/font/42055982/download/

@Finii
Copy link
Collaborator

Finii commented Mar 4, 2022

The 'source' is on Github, like ,,, https://github.com/be5invis/Iosevka/releases/tag/v15.0.1

You see that there are trillions of different font sets 🙄

Thought you would like ttf-iosevka-term-slab-15.0.1.zip.

Or if you can work with ttcs super-ttc-sgr-iosevka-term-slab-15.0.1.zip

Or ... whatever. That's why I ask, there are too many to choose from. With a lot of 'burnt in' SS (stylistic sets)....

Your links are for Iosevka Slab Regular and Medium.
This Issue was about Iosevka Term Slab
Hmm.

?? :-D

@eggbean
Copy link

eggbean commented Mar 4, 2022

@Finii Oh, well Iosevska Term Slab (Regular and Medium) would actually be what I would prefer, of course. I just didn't realise that it existed, as I couldn't find it. And I didn't realise that they were already in the repository.

What are super-tcc fonts? Do they include HJK characters or something like that?

@Finii
Copy link
Collaborator

Finii commented Mar 4, 2022

ttc = true type collection. Instead of having multiple files with one style/weight (i.e. bold, italic, ...) each, one file that contains all styles/weights of a family. In principle they all can share glyphs, which is ... not utilized at least by us.

Just easier to manage. I do not know if all OSs support them, probably yes.

super ... I have no clue.

The patch run for all most of ttf-iosevka-term-slab-15.0.1.zip is running right now.
Had to build fontforge first, that took some time, was debugging something in ff :-}

@eggbean
Copy link

eggbean commented Mar 4, 2022

Thanks for the help.

@Finii
Copy link
Collaborator

Finii commented Mar 4, 2022

  • Did the patching with fontforge version 20201107-246-g0bf72b2f8 (HEAD at the moment) (i.e. with 16 bit field fix that corrupted Iosevkas).
  • Did it with the new naming scheme, because the old naming is broken esp with fonts that have lots and lots of family members.

Patch results can be found here:
https://github.com/Finii/nerd-fonts/tree/feature/Add-Iosevka-Term-Slab-patched/patched-fonts/Iosevka

(Obviously I forgot Bold-Oblique ... sigh)

Note: Just the Term Slab variants were patched by me now, the other ones are untouched and can (i.e. will) contain errors.

Then, @ryanoasis: I believe we should change the directory structure:

At the moment we have

src/unpatched-fonts/Iosevka/Bold:
        iosevka-bold.ttf
        iosevka-term-bold.ttf
        iosevka-term-slab-bold.ttf
src/unpatched-fonts/Iosevka/Bold-Italic:
        iosevka-bolditalic.ttf
        iosevka-term-bolditalic.ttf
        iosevka-term-slab-bolditalic.ttf

which results in an equally set up patched-fonts/ result.

Usually - I believe - people do not mix different Iosevkas and would rather have one Family in one folder like so:

src/unpatched-fonts/Iosevka/Standard:
        iosevka-bold.ttf
        iosevka-bolditalic.ttf
src/unpatched-fonts/Iosevka/Term:
        iosevka-term-bold.ttf
        iosevka-term-bolditalic.ttf
src/unpatched-fonts/Iosevka/TermSlab:
        iosevka-term-slab-bold.ttf
        iosevka-term-slab-bolditalic.ttf

And/or with the Bold/ and Bold-Italic as sub folders.

I guess the reason for the Bold etc folders is, that the result will have 4 fonts for each input font, which can become confusing.

But then again, it is unlikely that people want a windows-compatible AND a normal font, so why are they grouped together?

What about

patched-fonts/
              standard/
              mono/
              windows-compat/
              mono-windows-compat/

And then the individual fonts below these?

Whatever. ;)

@Finii Finii mentioned this issue Mar 4, 2022
2 tasks
@eggbean
Copy link

eggbean commented Mar 6, 2022

It's insane how many variants this typeface has. Thanks a lot!

@Finii
Copy link
Collaborator

Finii commented Jan 30, 2023

Closing because transferred to #1095

@Finii Finii closed this as completed Jan 30, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants