-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore css parse errors and allow more versatile parsing implementations #108
Conversation
improve readability as to when the parsing really happens, deprecate parse()-methods with url passed on separate from the Page-object (in which it also resides)
…other content types
…r example haltOnError
… inside css content (having the css content with urls pointing to missing locations is preferable over not having it at all)
Made sure backwards compatibility is ok. When the timing is right, another improvement could be to group all classes under the parser-package depending on the content they act on, so introducing packages ...parser.html, ...parser.css, ...parser.text, and ...parser.binary. Changing the different parsers to "look" more like the way parsing is initiated for html content would also be nice, but probably not so great for backwards compatibility and very little gains other than more consequent code flows. |
Thx for the PR. We can do a 4.x release and move to 5.x with breaking changes. Wdyt? |
@rzo1: At the moment the only things left on my list are (in this order):
Point 1 and 2 are quick wins, not too much work. Only for 2 you would have to proofread and maybe elaborate on the frontiers part (I wrote the changes until now down, some "marketing effort" is warranted at this point I think). I believe you have experience with previous maintainer/contributors, so you are better placed to check documentation updates are correct and not offensive to them or anything. I was also thinking of making a high level design diagram to quickly have an overview of different parts in the code where one might want to extend. Do you know of/have preference for a tool? Point 3 shouldn't be hard either, I did this for very old code of myself last year. The reason it actually became a point on the agenda is that I noticed yesterday that the JUnit5 tests I committed don't break the Maven build if you introduce errors in them on purpose. Point 4 depends on your preference :-). I'm not a big believer in polyglot programming, but it takes time for history to prove either side right or wrong :-). Timing: I think I'll be elaborating my knowledge of WireMock within the next 6 months to a year (needed to make the migration). |
No description provided.