Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of "Events" helper in tests #1045

Closed
PaulRBerg opened this issue Sep 19, 2024 · 1 comment
Closed

Get rid of "Events" helper in tests #1045

PaulRBerg opened this issue Sep 19, 2024 · 1 comment
Assignees
@andreivladbrg
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

Starting Solidity v0.8.21, events can be emitted from interface files.

So we can get rid of the Events.t.sol file and duplicated events there and instead import the interface files from src.
@PaulRBerg PaulRBerg added priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. effort: low Easy or tiny task that takes less than a day. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Sep 19, 2024
@andreivladbrg
Copy link
Member

will address it in the test refactor PR https://github.com/sablier-labs/v2-core/tree/test/common-modifiers

@andreivladbrg andreivladbrg mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @andreivladbrg