Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-kit] Missing ordering parameters for getPendingTransactions #1010

Closed
dasanra opened this issue Oct 15, 2024 · 0 comments · Fixed by #1011
Closed

[api-kit] Missing ordering parameters for getPendingTransactions #1010

dasanra opened this issue Oct 15, 2024 · 0 comments · Fixed by #1011
Assignees
@dasanra

Comments

@dasanra
Copy link
Collaborator

dasanra commented Oct 15, 2024

Description

getPendingTransactions it`s not allowing to use many of the ordering parameters available at the enpoint. It should be possible to use:

  • ordering
  • limit
  • offset
  • has_confirmations

Environment

  • Safe Core SDK versions:
    • api-kit: 2.5.1

Steps to reproduce

It's not possible to use ordering properties

Expected result

It should be possible to switch ordering or using pagination parametersPlease describe concisely what you expect instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasanra dasanra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api-kit): add ordering props to getPendingTransactions safe-global/safe-core-sdk
1 participant
@dasanra