Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Run patchbot on all tickets, including those with package changes #148

Open
mkoeppe opened this issue Jan 23, 2022 · 3 comments
Open

Run patchbot on all tickets, including those with package changes #148

mkoeppe opened this issue Jan 23, 2022 · 3 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 23, 2022

Skipping tickets that involve package changes is an outdated, unnecessary restriction.
Just use configure --enable-download-from-upstream-url.

From https://groups.google.com/g/sage-devel/c/Qjhl1XHMll8/m/-uynTvkfBQAJ

@fchapoton
Copy link
Collaborator

This behaviour is here in patchbot.py :

                is_spkg = branch_updates_some_package() or ticket['spkgs']
                if is_spkg:
                    # ------------- treatment of spkgs -------------
                    state = 'spkg'
                    print("Ticket updates some package, hence not tested.")
                    self.to_skip[ticket['id']] = time.time() + 240 * 60 * 60

                if not is_spkg:

One can easily desactivate this check. Somebody needs to run a modified patchbot on a package-upgrade ticket to check that it works.

@fchapoton
Copy link
Collaborator

ok, now testing on #33160

@fchapoton
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants