-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisjointUnionEnumeratedSets should not always define Element and _element_constructor_ #10603
Comments
comment:1
I leave the patch as needs work because there is some dependency on another non finished patch (#10193). |
Dependencies: #10193 |
comment:4
Hello, you should add ticket number #10193 to the first line of the commit message. |
Changed keywords from DisjointUnionEnumeratedSets Element to DisjointUnionEnumeratedSets, Element, Cenay2012 |
Changed keywords from DisjointUnionEnumeratedSets, Element, Cenay2012 to DisjointUnionEnumeratedSets, Element, Cernay2012 |
comment:7
Removed (trivial) dependency to #10193 |
Changed dependencies from #10193 to none |
comment:8
Review done on the Sage-Combinat queue. All test pass. Positive review! |
Changed reviewer from Nicolas Thiéry to Nicolas M. Thiéry |
Merged: sage-5.0.beta6 |
When the argument
facade
is set toTrue
the attributesElement
and_element_constructor_
are defined by the classDisjointUnionEnumeratedSets
. This is a bad idea because it prevents a super class like a category to define them. The following patch fixes this problem.CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: DisjointUnionEnumeratedSets, Element, Cernay2012
Author: Florent Hivert
Reviewer: Nicolas M. Thiéry
Merged: sage-5.0.beta6
Issue created by migration from https://trac.sagemath.org/ticket/10603
The text was updated successfully, but these errors were encountered: