Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisjointUnionEnumeratedSets should not always define Element and _element_constructor_ #10603

Closed
hivert opened this issue Jan 12, 2011 · 11 comments

Comments

@hivert
Copy link

hivert commented Jan 12, 2011

When the argument facade is set to True the attributes Element and _element_constructor_ are defined by the class DisjointUnionEnumeratedSets. This is a bad idea because it prevents a super class like a category to define them. The following patch fixes this problem.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: DisjointUnionEnumeratedSets, Element, Cernay2012

Author: Florent Hivert

Reviewer: Nicolas M. Thiéry

Merged: sage-5.0.beta6

Issue created by migration from https://trac.sagemath.org/ticket/10603

@hivert
Copy link
Author

hivert commented Jan 12, 2011

comment:1

I leave the patch as needs work because there is some dependency on another non finished patch (#10193).

@hivert
Copy link
Author

hivert commented May 31, 2011

Dependencies: #10193

@fchapoton
Copy link
Contributor

comment:4

Hello, you should add ticket number #10193 to the first line of the commit message.

@hivert
Copy link
Author

hivert commented Feb 6, 2012

Changed keywords from DisjointUnionEnumeratedSets Element to DisjointUnionEnumeratedSets, Element, Cenay2012

@hivert
Copy link
Author

hivert commented Feb 6, 2012

Changed keywords from DisjointUnionEnumeratedSets, Element, Cenay2012 to DisjointUnionEnumeratedSets, Element, Cernay2012

@hivert
Copy link
Author

hivert commented Feb 14, 2012

comment:7

Removed (trivial) dependency to #10193

@hivert
Copy link
Author

hivert commented Feb 14, 2012

Changed dependencies from #10193 to none

@hivert
Copy link
Author

hivert commented Feb 14, 2012

@nthiery
Copy link
Contributor

nthiery commented Feb 14, 2012

comment:8

Review done on the Sage-Combinat queue. All test pass. Positive review!

@nthiery
Copy link
Contributor

nthiery commented Feb 14, 2012

Changed reviewer from Nicolas Thiéry to Nicolas M. Thiéry

@jdemeyer
Copy link

Merged: sage-5.0.beta6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants