Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make setuptools actually respect the --egg-path argument #13197

Closed
ohanar opened this issue Jul 3, 2012 · 15 comments
Closed

make setuptools actually respect the --egg-path argument #13197

ohanar opened this issue Jul 3, 2012 · 15 comments
Assignees
@sagetrac-GeorgSWeber
Labels
c: build r: invalid t: bug

Comments

@ohanar
Copy link
Member

ohanar commented Jul 3, 2012

Currently if you specify the egg-path when using setuptools' setup.py develop, it still places the absolute path in easy_install.pth. This causes issues with relocation. Currently this only affects the sage notebook (which works around it by using a sed command), but with #13190 it will also affect the sage library. Since the easy_install.pth file is regenerated whenever setuptools detects that it needs to be, trying to use sed commands to work around this issue is unrealistic.

New SPKG: http://wstein.org/home/ohanar/spkgs/setuptools-0.6.16.p1.spkg

Upstream: Reported upstream. No feedback yet.

CC: @kini @slel

Component: build

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/13197
@ohanar ohanar added this to the sage-5.11 milestone Jul 3, 2012
@ohanar
Copy link
Member Author

ohanar commented Jul 3, 2012

comment:1

I've attached an spkg which includes a work in progress patch that I intend to submit upstream once finished. It is currently functional for our purposes, hence the needs review.

@ohanar

This comment has been minimized.

Sign in to view
@ohanar
Copy link
Member Author

ohanar commented Jul 3, 2012

Author: R. Andrew Ohana

@ohanar
Copy link
Member Author

ohanar commented Jul 4, 2012

comment:2

Ok, I updated it with the actual patch I'm going to submit upstream, so there should be no hesitation on reviewing it now. Same URL.

@ohanar
Copy link
Member Author

ohanar commented Jul 4, 2012

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

@ohanar
Copy link
Member Author

ohanar commented Jul 4, 2012

comment:3

Upstream: http://bugs.python.org/setuptools/issue140

@ohanar
Copy link
Member Author

ohanar commented Jul 4, 2012

Changed upstream from Reported upstream. No feedback yet. to Not yet reported upstream; Will do shortly.

@ohanar
Copy link
Member Author

ohanar commented Jul 4, 2012

comment:4

And for distribute (which has more active development): https://bitbucket.org/tarek/distribute/issue/293/easy_installpth-doesnt-respect-develop-egg

@ohanar
Copy link
Member Author

ohanar commented Jul 4, 2012

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

@kini
Copy link
Contributor

kini commented Aug 31, 2012

comment:6

CCing myself since we should remove the sed stuff from the sagenb installer once this is in.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@kcrisman
Copy link
Member

comment:11

What's the status here? No branch, for instance, though setuptools in Sage is now at 12.4.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 17, 2020

comment:12

Outdated, should be closed

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 17, 2020

Changed author from R. Andrew Ohana to none

@mkoeppe mkoeppe removed this from the sage-6.4 milestone Aug 17, 2020
@slel
Copy link
Member

slel commented Aug 19, 2021

Reviewer: Samuel Lelièvre

@slel
Copy link
Member

slel commented Aug 19, 2021

comment:13

Let us close this.

@mkoeppe mkoeppe closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-GeorgSWeber sagetrac-GeorgSWeber

Labels
c: build r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kini @ohanar @kcrisman @slel @jdemeyer @mkoeppe