new methods for compositions

[saliola]

new functionality for the composition constructor:

• construct a composition from a subset

new functionality for compositions:

• parent -- returns Compositions()
• reversed - reverses
• refinement_splitting
• refinement_splitting_lengths
• deprecated refinement in favour of refinement_splitting_lengths
• partial_sums(self, final=True):
• to_subset(self, final=False):
• to_partition(self):
• shuffle_product(self, other, overlap=False):

new functionality for the set of all compositions:

• put it in the category of InfiniteEnumeratedSets
• subset method to extract subsets of composition (by size)

Apply:

• attachment: trac_13243-new_methods_for_compositions-fs.patch
• attachment: trac_13243-rebased_deprecated_function_alias-fs.patch
• attachment: trac_13243-review_changes-fs.patch
• attachment: trac_13243-documentation_fixes-fs.patch
• attachment: trac_13243-documentation_fixes_2-fs.patch

Depends on #13109

CC: @sagetrac-chrisjamesberg @sagetrac-sage-combinat @zabrocki

Component: combinatorics

Keywords: compositions, ncsf, sd40

Author: Franco Saliola, Nicolas M. Thiéry, Florent Hivert, Chris Berg

Reviewer: Chris Berg, Mike Zabrocki

Merged: sage-5.3.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13243

[saliola]

comment:3

Need to fix a dependency error. Patch coming 'soon'.

[saliola]

only apply this one

[saliola]

Attachment: trac_13243-new_methods_for_compositions-fs.patch.gz

Attachment: trac_13243-new_methods_for_compositions-fs.2.patch.gz

empty patch (this can be deleted)

[saliola]

comment:4

The errors were mainly due to the fact that the new category of graded enumerated sets does not yet exist (it exists on the sage-combinat queue, which is why tests passed on my machine). So I removed the two lines related to that.

I also modified a couple of doctests in permutation.py, which was caused by the change the descents method.

[saliola]

comment:5

Apply: trac_13243-new_methods_for_compositions-fs.patch

[saliola]

Attachment: trac_13243-rebased_deprecated_function_alias-fs.patch.gz

needed for 5.2.rc0 (updated the call to deprecated_function_alias)

[saliola]

Dependencies: #13109

[saliola]

comment:7

Apply: trac_13243-new_methods_for_compositions-fs.patch, trac_13243-rebased_deprecated_function_alias-fs.patch

(for the patchbot)

[saliola]

comment:9

Note that the patches attached to this ticket are newer than the patches on the sage-combinat queue.

Also, I'm in the process of updating this patch with improvements suggested by Mike. New version will be available soon.

[saliola]

Attachment: trac_13243-review_changes-fs.patch.gz

changes based on Mike's review

[saliola]

comment:10

Here is a patch (trac_13243-review_changes-fs.patch), which should be applied on top of the earlier patch, that includes improvements suggested by Mike.

Patchbot:

Apply: trac_13243-new_methods_for_compositions-fs.patch, trac_13243-rebased_deprecated_function_alias-fs.patch, trac_13243-review_changes-fs.patch, trac_13243-documentation_fixes-fs.patch

[saliola]

Changed reviewer from Chris Berg to Chris Berg, Mike Zabrocki

[saliola]

comment:13

Attachment: trac_13243-documentation_fixes-fs.patch.gz

Hello Mike,

Here is a final patch fixing some the issues with the documentation. The documentation now builds and renders nicely. Thanks for your suggestions.

I made separate patches so that it is easier for you to look at my recent changes (but if you prefer, I can post one patch). You only need to look at the following two files to see the changes I made after your review of the first patch:

• trac_13243-review_changes-fs.patch
• trac_13243-documentation_fixes-fs.patch

Franco

[saliola]

comment:14

Mike suggested some more documentation improvements. New patch on the way.

[saliola]

Work Issues: documentation improvements

[saliola]

improvements to documentation for shuffle_product

[saliola]

comment:15

Attachment: trac_13243-documentation_fixes_2-fs.patch.gz

Here is a patch with improvements to the documentation of shuffle product.

Patchbot:

Apply: trac_13243-new_methods_for_compositions-fs.patch, trac_13243-rebased_deprecated_function_alias-fs.patch, trac_13243-review_changes-fs.patch, trac_13243-documentation_fixes-fs.patch, trac_13243-documentation_fixes_2-fs.patch

[saliola]

Changed work issues from documentation improvements to none

[anneschilling]

comment:18

Hi Franco,

You promised to import these patches also to the sage-combinat queue, since the current patch there completely breaks sage-5.2.rc0. I am confused as to which patches are supposed to be applied. For example trac_13243-rebased_deprecated_function_alias-fs.patch also has a newer version trac_13243-rebased_deprecated_function_alias-fs.2.patch, but this is not the one listed in your list.

Thanks,

Anne

[jdemeyer]

comment:19

Please clarify which patches have to be applied.

[saliola]

comment:21

Replying to @jdemeyer:

Please clarify which patches have to be applied.

If I understand correctly, the patchbot doesn't look at the description for the "apply" directive, so I put it in the comments. Should I also include the directive in the description? Is there a preferred syntax for this?

Apply: trac_13243-new_methods_for_compositions-fs.patch, trac_13243-rebased_deprecated_function_alias-fs.patch, trac_13243-review_changes-fs.patch, trac_13243-documentation_fixes-fs.patch, trac_13243-documentation_fixes_2-fs.patch

For humans:

• attachment: trac_13243-new_methods_for_compositions-fs.patch
• attachment: trac_13243-rebased_deprecated_function_alias-fs.patch
• attachment: trac_13243-review_changes-fs.patch
• attachment: trac_13243-documentation_fixes-fs.patch
• attachment: trac_13243-documentation_fixes_2-fs.patch

[jdemeyer]

comment:25

Replying to @saliola:

If I understand correctly, the patchbot doesn't look at the description for the "apply" directive, so I put it in the comments.

I think that's correct yes.

Should I also include the directive in the description?

Yes please!

[saliola]

comment:26

Replying to @jdemeyer:

Replying to @saliola:

If I understand correctly, the patchbot doesn't look at the description for the "apply" directive, so I put it in the comments.

I think that's correct yes.

Should I also include the directive in the description?

Yes please!

Thank you. I'll make sure to do this from now on!

[jdemeyer]

Merged: sage-5.3.beta0

[jdemeyer]

Changed author from Franco Saliola, Nicolas Thiery, Florent Hivert, Chris Berg to Franco Saliola, Nicolas M. Thiéry, Florent Hivert, Chris Berg