-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of symmetric function code #14220
Comments
This comment has been minimized.
This comment has been minimized.
Changed author from zabrocki to Mike Zabrocki |
comment:3
Attachment: trac_14220_symmetric_function_cleanup-mz.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:5
I have added a tiny patch, trying to ensure that all tests pass in ncsf If the bot turns green, I will give a positive review |
Reviewer: Frédéric Chapoton |
comment:6
positive review |
comment:7
Thanks for the review and for catching the ncsf cleanup. |
comment:8
This needs to be rebased to sage-5.9.beta0. |
Attachment: trac_14220_sym_clean-fc.2.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:10
This applied cleanly for me so I'm setting this back to positive review. |
comment:11
Hi Travis. Thanks for coming back to this one. |
This comment has been minimized.
This comment has been minimized.
Merged: sage-5.9.beta4 |
Recent tickets which changed the symmetric function code (potentially #5457, #13399, #13404, #13762, but maybe others) included unnecessary import statements and lines that raise warnings with pyflakes. This ticket corrects most of these warnings plus minor cleanup of the symmetric function code.
This sort of cleanup in new_kschur.py and k_dual.py is done in #13743, #14235, #14237
Apply:
Depends on #13605
CC: @anneschilling @saliola @sagetrac-chrisjamesberg
Component: combinatorics
Keywords: symmetric functions, pyflakes
Author: Mike Zabrocki
Reviewer: Frédéric Chapoton
Merged: sage-5.9.beta4
Issue created by migration from https://trac.sagemath.org/ticket/14220
The text was updated successfully, but these errors were encountered: