-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workaround for sagenb pull request 84 #14273
Comments
Author: R. Andrew Ohana |
Reviewer: Jeroen Demeyer |
comment:4
Assuming that sagemath/sagenb#84 is merged, this patch is obviously fine. |
apply to sage library |
comment:5
Attachment: trac14273.patch.gz Rebased to #14266 and removed an additional workaround in |
comment:8
These changes were apparently used as workarounds for the old sagenb in #12415. I ran the following
and all the tests passed. So, removing this workaround looks ok to me now. |
Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Punarbasu Purkayastha |
Branch: u/tkluck/ticket/14273 |
Merged: sage-5.12.beta0 |
In #12415 we added
to
sage.doctest.forker
. These whould be removed once the newer version of sagenb is incorporated into Sage.Depends on #12415
Depends on #14330
Depends on #14266
CC: @kini @jdemeyer
Component: doctest framework
Author: R. Andrew Ohana
Branch: u/tkluck/ticket/14273
Reviewer: Jeroen Demeyer, Punarbasu Purkayastha
Merged: sage-5.12.beta0
Issue created by migration from https://trac.sagemath.org/ticket/14273
The text was updated successfully, but these errors were encountered: