Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython dependency checking broken #14544

Closed
jdemeyer opened this issue May 7, 2013 · 9 comments
Closed

Cython dependency checking broken #14544

jdemeyer opened this issue May 7, 2013 · 9 comments

Comments

@jdemeyer
Copy link

jdemeyer commented May 7, 2013

Install the PARI spkg from #14539:

./sage -i http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.4.p0.spkg

Then rebuild the library:

./sage -b

Before #13031, this used to rebuild all files depending on PARI (good!), with #13031 absolutely nothing happens (bad!).

spkg: http://sage.math.washington.edu/home/robertwb/patches/cython-0.19.p1.spkg

apply attachment: 14544-cythonize-deps.patch to the Sage library

CC: @robertwb

Component: cython

Author: Robert Bradshaw

Reviewer: Jeroen Demeyer

Merged: sage-5.10.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14544

@jdemeyer jdemeyer added this to the sage-5.10 milestone May 7, 2013
@jdemeyer jdemeyer self-assigned this May 7, 2013
@robertwb
Copy link
Contributor

robertwb commented May 8, 2013

comment:1

Attachment: 14544-cythonize-deps.patch.gz

This requires a fix to the Sage library as well as cython/cython@5574592

@robertwb
Copy link
Contributor

robertwb commented May 8, 2013

@jdemeyer
Copy link
Author

jdemeyer commented May 8, 2013

Author: Robert Bradshaw

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented May 8, 2013

Merged: sage-5.10.beta2

@jdemeyer
Copy link
Author

jdemeyer commented May 8, 2013

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Author

jdemeyer commented May 8, 2013

comment:4

Looks good to me.

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented May 17, 2013

comment:5

It's not that closed in fact : what does deps.patch do? It isn't documented in SPKG.txt, and the log message only says who wrote it but not why. And since it is an upstream modification, was it forwarded?

@jdemeyer
Copy link
Author

comment:6

The author of the patch is upstream. Anyway, #14569 solved your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants