-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove import of is_* in matrix.all #15098
Comments
Author: Frédéric Chapoton |
comment:4
Attachment: trac_15098_remove_global_is_in_matrix.patch.gz I'm not quite sure what would constitute a review of this. How can a change like this cause any bugs if the doctests don't fail? |
comment:5
Yes, indeed. So this should be an easy thing to review.. |
Attachment: trac_15098_review-dg.patch.gz |
comment:6
Great, this is done then. If you are OK with my changes, set this to positive_review. for the patchbot: apply trac_15098_remove_global_is_in_matrix.patch trac_15098_review-dg.patch |
Reviewer: Darij Grinberg |
This comment has been minimized.
This comment has been minimized.
comment:7
Thanks Darij ! I now set this to positive review. |
Merged: sage-5.13.beta3 |
this is a follow-up of #15076
and a step towards #14329
Apply:
Depends on #15076
Component: linear algebra
Keywords: deprecation cleanup
Author: Frédéric Chapoton
Reviewer: Darij Grinberg
Merged: sage-5.13.beta3
Issue created by migration from https://trac.sagemath.org/ticket/15098
The text was updated successfully, but these errors were encountered: