Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 preparation: Change backticks into repr() #15992

Closed
wluebbe mannequin opened this issue Mar 20, 2014 · 16 comments
Closed

Python 3 preparation: Change backticks into repr() #15992

wluebbe mannequin opened this issue Mar 20, 2014 · 16 comments

Comments

@wluebbe
Copy link
Mannequin

wluebbe mannequin commented Mar 20, 2014

Backticks are deprecated since long ago and not accepted by Python 3.

Changes according to lib2to3/fixes/fix_repr.py:

transforms `xyzzy` into repr(xyzzy)

This ticket is tracked as a dependency of meta-ticket ticket:15980.

Component: distribution

Author: Wilfried Luebbe

Branch/Commit: 7daa857

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/15992

@wluebbe wluebbe mannequin added this to the sage-6.2 milestone Mar 20, 2014
@wluebbe wluebbe mannequin added c: distribution labels Mar 20, 2014
@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 22, 2014

comment:1

2to3 changed 4 affected .py modules.

I have not found a way to identify the relevant backtick usages (too many backticks in comments and doc-test):

  • .pyx modules may be affected. But cython is said to be Python 3 enabled, so that should be no problem.
  • If there backticks in doc-tests they will be found during tests in a Python 3 environment.

New commits:

289b346changes the deprecated backticks usage to repr() function calls

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 22, 2014

Branch: u/wluebbe/ticket/15992

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 22, 2014

Commit: 289b346

@wluebbe wluebbe mannequin added the s: needs review label Mar 22, 2014
@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 22, 2014

comment:2

Apparently the automerge fails. How to locate the conflicting parts?

@wluebbe wluebbe mannequin added s: needs work and removed s: needs review labels Mar 22, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8c99a20changes the deprecated backticks usage to repr() function calls

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 26, 2014

Changed commit from 289b346 to 8c99a20

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 26, 2014

comment:4

branch was rebased to resolve merge conflict

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Mar 27, 2014

comment:5

I did

git merge u/chapoton/15991 u/wluebbe/ticket/15986 u/wluebbe/ticket/15987

on top of u/wluebbe/ticket/15992 (which is rebased on 6.2.beta5)

Test report:

./sage -t -p --all --long --logfile=logs/ptestlong-alle4.log
...
All tests passed!

@wluebbe wluebbe mannequin added s: needs review and removed s: needs work labels Mar 27, 2014
@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Changed branch from u/wluebbe/ticket/15992 to public/ticket/15992

@fchapoton
Copy link
Contributor

Changed commit from 8c99a20 to 7daa857

@fchapoton
Copy link
Contributor

comment:6

Here is a reviewer branch. I have taken the opportunity to make small changes in the close nieghborhood of the modified code, and to add some doctests.

If you agree with my changes, you can set this to positive review.


New commits:

7daa857trac #15992 reviewer patch

@tscrim
Copy link
Collaborator

tscrim commented Mar 29, 2014

comment:7

Eeek, I'm surprised I've never noticed that not raising an error message in NCSF. I agree with the changes, so positive review.

@tscrim
Copy link
Collaborator

tscrim commented Mar 29, 2014

Author: Wilfried Luebbe

@tscrim
Copy link
Collaborator

tscrim commented Mar 29, 2014

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 1, 2014

Changed branch from public/ticket/15992 to 7daa857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants