-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 preparation: Change backticks into repr() #15992
Comments
comment:1
2to3 changed 4 affected .py modules. I have not found a way to identify the relevant backtick usages (too many backticks in comments and doc-test):
New commits:
|
Branch: u/wluebbe/ticket/15992 |
Commit: |
comment:2
Apparently the automerge fails. How to locate the conflicting parts? |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:4
branch was rebased to resolve merge conflict |
comment:5
I did
on top of Test report:
|
Reviewer: Frédéric Chapoton |
Changed branch from u/wluebbe/ticket/15992 to public/ticket/15992 |
comment:6
Here is a reviewer branch. I have taken the opportunity to make small changes in the close nieghborhood of the modified code, and to add some doctests. If you agree with my changes, you can set this to positive review. New commits:
|
comment:7
Eeek, I'm surprised I've never noticed that not raising an error message in NCSF. I agree with the changes, so positive review. |
Author: Wilfried Luebbe |
Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Travis Scrimshaw |
Changed branch from public/ticket/15992 to |
Backticks are deprecated since long ago and not accepted by Python 3.
Changes according to
lib2to3/fixes/fix_repr.py
:This ticket is tracked as a dependency of meta-ticket ticket:15980.
Component: distribution
Author: Wilfried Luebbe
Branch/Commit:
7daa857
Reviewer: Frédéric Chapoton, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/15992
The text was updated successfully, but these errors were encountered: