Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Cython 0.25.1 #20596

Closed
jdemeyer opened this issue May 12, 2016 · 51 comments
Closed

Upgrade to Cython 0.25.1 #20596

jdemeyer opened this issue May 12, 2016 · 51 comments

Comments

@jdemeyer
Copy link

Tarball: https://pypi.python.org/packages/2f/ae/0bb6ca970b949d97ca622641532d4a26395322172adaf645149ebef664eb/Cython-0.25.1.tar.gz

Depends on #21697
Depends on #21600

CC: @robertwb

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 922fa16

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/20596

@jdemeyer jdemeyer added this to the sage-7.3 milestone May 12, 2016
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/20596

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

New commits:

60788fdWork around Cython bug #879

@jdemeyer
Copy link
Author

Commit: 60788fd

@jdemeyer jdemeyer removed this from the sage-7.3 milestone May 12, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Changed commit from 60788fd to 51c0bcb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

51c0bcbWork around Cython bug #879

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2016

Changed commit from 51c0bcb to 766dfb0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

766dfb0Work around Cython bug #879

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Work around Cython bug #879 Work around Cython bug #1433 Aug 17, 2016
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Changed upstream from Reported upstream. No feedback yet. to none

@jdemeyer jdemeyer changed the title Work around Cython bug #1433 Upgrade to Cython 0.25 Sep 13, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6e1a932Move directives to cythonize() call

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Changed commit from 766dfb0 to 6e1a932

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

699f1f8Move old_style_globals to modules; other directives to cythonize() call

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Changed commit from 6e1a932 to 699f1f8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Changed commit from 699f1f8 to 42d3e05

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

42d3e05Move old_style_globals to modules; other directives to cythonize() call

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2016

Changed commit from 42d3e05 to 00cd961

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2016

Changed commit from ffbfdb8 to 6a9474b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

77eb8e2Move old_style_globals to individual modules
6a9474bUpgrade Cython to version 0.25

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer added this to the sage-7.5 milestone Oct 26, 2016
@jdemeyer jdemeyer removed the pending label Oct 26, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

990c482Upgrade Cython to version 0.25

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2016

Changed commit from 6a9474b to 990c482

@jdemeyer

This comment has been minimized.

@kiwifb
Copy link
Member

kiwifb commented Oct 27, 2016

comment:29

I have seen 0.25.1 is out to fix some unexpected bugs, do we care?

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

comment:30

Replying to @kiwifb:

I have seen 0.25.1 is out to fix some unexpected bugs, do we care?

I guess we should care.

@jdemeyer jdemeyer changed the title Upgrade to Cython 0.25 Upgrade to Cython 0.25.1 Oct 27, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 27, 2016

Changed commit from 990c482 to 922fa16

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 27, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

922fa16Upgrade Cython to version 0.25.1

@kiwifb
Copy link
Member

kiwifb commented Oct 27, 2016

comment:32

I am ready to put this in positive review unless you have something else to do before putting it back from "need_work" to "need_review".

@jdemeyer
Copy link
Author

Reviewer: François Bissey

@jdemeyer
Copy link
Author

comment:33

I guess I need to test Sage again with Cython 0.25.1. That will be not for today.

@vbraun
Copy link
Member

vbraun commented Oct 29, 2016

Changed branch from u/jdemeyer/ticket/20596 to 922fa16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants