convert some imports in combinat to absolute imports

[fchapoton]

Let us try to start using the absolute import everywhere.

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 7d586f0

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20617

[fchapoton]

Commit: 4a03357

[fchapoton]

Branch: public/20617

[fchapoton]

New commits:

4a03357

convert some imports in combinat to absolute imports

[sagetrac-git]

Changed commit from 4a03357 to 1c74237

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1c74237

more import changes in combinat

[sagetrac-git]

Changed commit from 1c74237 to 3b5e552

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3b5e552

another import change in combinat/all

[jdemeyer]

comment:4

Would it not be better to add from future import absolute_import then?

[fchapoton]

comment:5

I thought this was not necessary since python 2.7.

Or maybe you mean, to avoid some backward move, like people re-introducing old-style imports ?

[jdemeyer]

comment:6

Replying to @fchapoton:

Or maybe you mean, to avoid some backward move, like people re-introducing old-style imports ?

Yes exactly.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2a0ed11

trac 20617 adding future import absolute_import

[sagetrac-git]

Changed commit from 3b5e552 to 2a0ed11

[sagetrac-git]

Changed commit from 2a0ed11 to 5add1af

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5add1af

trac 20617 better placement of future import

[fchapoton]

comment:9

ok, this one does pass the tests (except for the 4 failures coming from somewhere else, see #20529, which prevents my patchbot to work smoothly)

[jdemeyer]

comment:10

I'm sorry but I keep seeing strange things in the files that you update...

What is the point of __doc__ = r""" instead of a normal docstring?

[fchapoton]

comment:11

no idea. This was there before, maybe this can stay ?

[jdemeyer]

comment:12

See #20633 for the silly __doc__ stuff.

Suggestion: leave those modules alone in this ticket.

[fchapoton]

comment:13

why ? ticket #20633 can wait for its turn to come, no ?

[jdemeyer]

comment:14

If it's easy to make two tickets not conflict, I think that's the best way.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

23b5775

removing the future where conflict may happen with other ticket

[sagetrac-git]

Changed commit from 5add1af to 23b5775

[jdemeyer]

comment:16

Two more things:

1. Are you sure you need those from . import all statements? I don't see the point.

2. In src/sage/combinat/__init__.py, can you remove those commented-out imports?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7d586f0

trac 20617, details after reviewer's comments

[sagetrac-git]

Changed commit from 23b5775 to 7d586f0

[jdemeyer]

comment:18

positive_review modulo the patchbot.

[jdemeyer]

Reviewer: Jeroen Demeyer

[fchapoton]

comment:19

ok, patchbot is "green", modulo the usual 4 failing doctests from #20529

setting to positive review. Thanks !

[vbraun]

Changed branch from public/20617 to 7d586f0