-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch pip to work without SSL support #20913
Comments
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
Do you happen to know how this should be tested, i.e. can I "fake" that I don't have SSL? |
comment:4
Replying to @jdemeyer:
Sure. For example put a module called Welcome back, also! |
comment:5
Can you add links in the ticket description to the upstream issue? |
Reviewer: Jeroen Demeyer |
comment:6
Works fine. |
Changed branch from u/embray/pip-ssl-patch to |
This comment has been minimized.
This comment has been minimized.
Changed commit from |
This fixes a long-standing issue where if Sage is built on a system without OpenSSL support, doing anything with pip will result in it crashing.
This allows pip to work without SSL support. Its functionality is limited--i.e. it can't download anything from PyPI without SSL. But it does have appropriate error-handling in this case, an can still be used to install local packages fine.
This was originally part of #20218 but I am breaking it out to a separate ticket as requested.
The relevant upstream issue is here: pypa/pip#1165
Upstream: Reported upstream. Developers acknowledge bug.
Component: packages: standard
Keywords: pip
Author: Erik Bray
Branch:
b18d84d
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/20913
The text was updated successfully, but these errors were encountered: