Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch pip to work without SSL support #20913

Closed
embray opened this issue Jun 30, 2016 · 10 comments
Closed

Patch pip to work without SSL support #20913

embray opened this issue Jun 30, 2016 · 10 comments

Comments

@embray
Copy link
Contributor

embray commented Jun 30, 2016

This fixes a long-standing issue where if Sage is built on a system without OpenSSL support, doing anything with pip will result in it crashing.

This allows pip to work without SSL support. Its functionality is limited--i.e. it can't download anything from PyPI without SSL. But it does have appropriate error-handling in this case, an can still be used to install local packages fine.

This was originally part of #20218 but I am breaking it out to a separate ticket as requested.

The relevant upstream issue is here: pypa/pip#1165

Upstream: Reported upstream. Developers acknowledge bug.

Component: packages: standard

Keywords: pip

Author: Erik Bray

Branch: b18d84d

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20913

@embray embray added this to the sage-7.3 milestone Jun 30, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b18d84dBump pip package patch level

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2016

Changed commit from 71af670 to b18d84d

@jdemeyer
Copy link

comment:3

Do you happen to know how this should be tested, i.e. can I "fake" that I don't have SSL?

@embray
Copy link
Contributor Author

embray commented Jul 13, 2016

comment:4

Replying to @jdemeyer:

Do you happen to know how this should be tested, i.e. can I "fake" that I don't have SSL?

Sure. For example put a module called ssl.py that does nothing but raise an ImportError somewhere early on your PYTHONPATH. That's how I tested this.

Welcome back, also!

@jdemeyer
Copy link

comment:5

Can you add links in the ticket description to the upstream issue?

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:6

Works fine.

@vbraun
Copy link
Member

vbraun commented Jul 14, 2016

Changed branch from u/embray/pip-ssl-patch to b18d84d

@embray

This comment has been minimized.

@embray
Copy link
Contributor Author

embray commented Jul 15, 2016

Changed commit from b18d84d to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants