Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install src/bin/* scripts via setup.py (scripts, console_scripts) #21569

Closed
mkoeppe opened this issue Sep 22, 2016 · 9 comments
Closed

Install src/bin/* scripts via setup.py (scripts, console_scripts) #21569

mkoeppe opened this issue Sep 22, 2016 · 9 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 22, 2016

Currently the scripts in src/bin are installed by build/make/Makefile.

As part of #21507, for those scripts that should be considered part of sagelib, the installation should be done by src/setup.py instead, using the scripts and console-scripts features.

(Example, received from was: ​https://github.com/sagemathinc/smc/tree/master/src/smc_pyutil. See, in particular, the console_scripts section of setup.py: ​https://github.com/sagemathinc/smc/blob/master/src/smc_pyutil/setup.py#L58)

(Those scripts that don't belong into src/bin are moved to build/bin by #21559.
See also: #21570: Move non-scripts of src/bin/ elsewhere (and also move their install location; #21707: Split sage-env into sage-build-env and sage-env)

CC: @williamstein @vbraun @jdemeyer @embray @kiwifb @nexttime @tobihan @saraedum @dimpase @isuruf @fchapoton

Component: build

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/21569

@mkoeppe mkoeppe added this to the sage-7.4 milestone Sep 22, 2016
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@embray
Copy link
Contributor

embray commented Sep 23, 2016

comment:4

+1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 14, 2016

comment:5

Erik, Jeroen - should this be done on top of #21604 and #21600; or does it have to wait for other tickets?

@embray
Copy link
Contributor

embray commented Oct 14, 2016

comment:6

Normally this shouldn't be dependent on those tickets, and I can't think of any reason it would be. But I've come not to expect normalcy with sage.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 2, 2018

comment:8

In #22731 comment 28, it is proposed to move scripts to $SAGE_LOCAL/libexec.
Could a setuptools expert comment whether setup.sh would be able to do this, or can it only install into bin (via the scripts and console_scripts features)?

@mkoeppe mkoeppe modified the milestones: sage-7.4, sage-9.1 Feb 21, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 2, 2020

comment:10

I'm taking care of this task in #21559.
The present ticket can be closed as a duplicate.

@mkoeppe mkoeppe removed this from the sage-9.1 milestone Mar 2, 2020
@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants