-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the .cython_version format to include all cythonize options #21843
Comments
New commits:
|
Author: Jeroen Demeyer |
Commit: |
comment:4
Thanks--straightforward enough. |
comment:6
cough cough |
Reviewer: Erik Bray |
Changed branch from u/jdemeyer/update_the__cython_version_format_to_include_all_cythonize_options to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed beginning here, the current
.cython_version
stamp does not always accurately reflect all Cython build options which, if changed, should trigger a rebuild of Cython sources.It would be good to have a more detailed
.cython_version
that includes all arguments tocythonize()
and perhaps allCython.Compiler.Options
.Although the values of these options are generally simple types, the
compiler_directives
dict alone makes this data structure complicated enough that an ad hoc format like the one currently used is not justified--instead a json-formatted file should work.Component: build
Author: Jeroen Demeyer
Branch/Commit:
b56b4be
Reviewer: Erik Bray
Issue created by migration from https://trac.sagemath.org/ticket/21843
The text was updated successfully, but these errors were encountered: