absolute_import in Cython files

[jdemeyer]

Depends on #22806

CC: @fchapoton

Component: python3

Author: Jeroen Demeyer

Branch/Commit: ac72aa1

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/22808

[fchapoton]

comment:1

one step in #22975

[fchapoton]

comment:2

next step in #23068

[fchapoton]

comment:3

next step in #23589

[fchapoton]

comment:4

next step in #23641

[fchapoton]

comment:5

next step in #23662

[fchapoton]

comment:6

maybe the last step in #23745

but how can we check ?

[fchapoton]

comment:7

Jeroen, do you have an idea how to find places where adding "absolute_import" is still needed ?

[jdemeyer]

comment:8

Do you mean for Python and Cython code in the Sage library or only Cython code?

[fchapoton]

comment:9

Well, only Cython, to deal with this ticket. But of course one should also check for py files.

[jdemeyer]

comment:10

OK, both Python and Cython. I think it is best to treat Python and Cython the same here. Imports work the same way. The only difference is that Cython also has cimport.

I think that I only created this ticket because at some point you were adding from future import absolute_import to a lot of Python files but not to Cython files. It seemed like you overlooked Cython files.

[fchapoton]

comment:11

So what should we do here ?

I would like to have some certitude before closing, but I do not know how to test that everything is in order.

[jdemeyer]

comment:12

Actually, it might be easy to force Cython to use absolute_import everywhere. Maybe we can try the same thing with print_function.

[fchapoton]

comment:13

Replying to @jdemeyer:

Actually, it might be easy to force Cython to use absolute_import everywhere. Maybe we can try the same thing with print_function.

any idea on how to do that ?

[jdemeyer]

comment:14

Replying to @fchapoton:

any idea on how to do that ?

Yes.

[jdemeyer]

Branch: u/jdemeyer/absolute_import_in_cython_files

[jdemeyer]

Commit: ac72aa1

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

comment:16

Just one change required...

---

New commits:

ac72aa1

Fix relative cimport

[fchapoton]

comment:17

Great !
Does this mean that you tried to compile while forcing cython to use absolute import, and this was the only failure ?

[jdemeyer]

comment:18

Replying to @fchapoton:

Great !
Does this mean that you tried to compile while forcing cython to use absolute import, and this was the only failure ?

Yes. I didn't run doctests, but at least built and ran Sage.

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:19

Then let us consider that this ticket is fixed. Thanks !

[vbraun]

Changed branch from u/jdemeyer/absolute_import_in_cython_files to ac72aa1