Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: get rid of cmp in totally real fields #23698

Closed
fchapoton opened this issue Aug 24, 2017 · 8 comments
Closed

py3: get rid of cmp in totally real fields #23698

fchapoton opened this issue Aug 24, 2017 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@fchapoton
Copy link
Contributor

as another step to py3

Component: python3

Keywords: days88, IMA coding sprints

Author: Frédéric Chapoton

Branch/Commit: feb4dd0

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23698
@fchapoton fchapoton added this to the sage-8.1 milestone Aug 24, 2017
@fchapoton
Copy link
Contributor Author

New commits:

feb4dd0py3: get rid of cmp in totally real fields

@fchapoton
Copy link
Contributor Author

Commit: feb4dd0

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23698

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2017

comment:2

If the patchbot comes back green, then you can set a positive review on my behalf.

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2017

Changed keywords from none to days88, IMA coding sprints

@fchapoton
Copy link
Contributor Author

comment:4

bot is morally green, setting to positive. Thank you, Travis.

@vbraun
Copy link
Member

vbraun commented Sep 4, 2017

Changed branch from u/chapoton/23698 to feb4dd0

@vbraun vbraun closed this as completed in ef9c692 Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton