Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Sphinx 1.7.6 #26033

Closed
jdemeyer opened this issue Aug 9, 2018 · 8 comments
Closed

Upgrade to Sphinx 1.7.6 #26033

jdemeyer opened this issue Aug 9, 2018 · 8 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@jdemeyer
Copy link

jdemeyer commented Aug 9, 2018

Tarball: https://files.pythonhosted.org/packages/eb/3c/702e89ad33529c0107d44ebc1a7eca97c4fd77ae2784060923a65864fcbd/Sphinx-1.7.6.tar.gz

CC: @embray @kiwifb

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 9508f39

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/26033
@jdemeyer jdemeyer added this to the sage-8.4 milestone Aug 9, 2018
@jdemeyer
Copy link
Author

jdemeyer commented Aug 9, 2018

Branch: u/jdemeyer/upgrade_to_sphinx_1_7_6

@kiwifb
Copy link
Member

kiwifb commented Aug 9, 2018

New commits:

9508f39Upgrade to Sphinx 1.7.6

@kiwifb
Copy link
Member

kiwifb commented Aug 9, 2018

Commit: 9508f39

@embray
Copy link
Contributor

embray commented Aug 16, 2018

comment:4

Assuming you've tested this, then I can't imagine any reason not to.

@jdemeyer
Copy link
Author

comment:5

Is that a rephrasing of "positive review"?

@embray
Copy link
Contributor

embray commented Aug 17, 2018

comment:6

It means, "I haven't tested this myself because too lazy, but if you have and it worked then feel free to set positive review".

@embray
Copy link
Contributor

embray commented Aug 17, 2018

Reviewer: Erik Bray

@vbraun
Copy link
Member

vbraun commented Aug 25, 2018

Changed branch from u/jdemeyer/upgrade_to_sphinx_1_7_6 to 9508f39

@vbraun vbraun closed this as completed in f3cd2c6 Aug 25, 2018
@saraedum saraedum mentioned this issue Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
4 participants
@kiwifb @embray @vbraun @jdemeyer