Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the doctest flag "optional - gmpy2" #27402

Closed
videlec opened this issue Mar 3, 2019 · 9 comments
Closed

remove the doctest flag "optional - gmpy2" #27402

videlec opened this issue Mar 3, 2019 · 9 comments
Labels
c: packages: standard p: major / 3 t: bug
Milestone
sage-8.7

Comments

@videlec
Copy link
Contributor

videlec commented Mar 3, 2019

#23024 made gmpy2 a standard package but there are still some doctest flags in src/sage/arith/misc.py and src/sage/structure/coerce.pyx. The presence of these flags imply that the corresponding tests are not run.

CC: @vinklein

Component: packages: standard

Author: Vincent Delecroix

Branch/Commit: 635c4ab

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/27402
@videlec videlec added this to the sage-8.7 milestone Mar 3, 2019
@videlec
Copy link
Contributor Author

videlec commented Mar 3, 2019

Branch: u/vdelecroix/27402

@videlec
Copy link
Contributor Author

videlec commented Mar 3, 2019

New commits:

58f2cecremove the doctest flag "optional - gmpy2"

@videlec
Copy link
Contributor Author

videlec commented Mar 3, 2019

Commit: 58f2cec

@fchapoton
Copy link
Contributor

comment:2

failing doctests, see patchbot

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 3, 2019

Changed commit from 58f2cec to 635c4ab

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 3, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

635c4abremove the doctest flag "optional - gmpy2"

@videlec
Copy link
Contributor Author

videlec commented Mar 3, 2019

comment:4

I don't know why I missed one flag...

@vinklein vinklein mannequin self-assigned this Mar 4, 2019
@jdemeyer
Copy link

jdemeyer commented Mar 4, 2019

Reviewer: Jeroen Demeyer

@vinklein vinklein mannequin removed their assignment Mar 4, 2019
@vbraun
Copy link
Member

vbraun commented Mar 5, 2019

Changed branch from u/vdelecroix/27402 to 635c4ab

@vbraun vbraun closed this as completed in 839360d Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
4 participants
@vbraun @jdemeyer @fchapoton @videlec