Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rpy 3.x #28988

Closed
antonio-rojas opened this issue Jan 11, 2020 · 8 comments
Closed

Support rpy 3.x #28988

antonio-rojas opened this issue Jan 11, 2020 · 8 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@antonio-rojas
Copy link
Contributor

This ticket adds support for rpy 3.x while keeping support for rpy 2.x.

This is done by defining rpy2py as cv.rpy2py for rpy 3.x and as cv.ri2py for rpy 2.x.

CC: @slel

Component: interfaces

Keywords: rpy

Author: Antonio Rojas

Branch/Commit: 6e67c65

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28988
@antonio-rojas antonio-rojas added this to the sage-9.1 milestone Jan 11, 2020
@antonio-rojas
Copy link
Contributor Author

Branch: u/arojas/support_rpy_3_x

@antonio-rojas
Copy link
Contributor Author

Commit: 6e67c65

@antonio-rojas
Copy link
Contributor Author

comment:2

Support both 2.x and 3.x versions of rpy. rpy can't be updated yet since 3.x is python3-only.

New commits:

6e67c65Support both rpy 2.x and 3.x

@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@isuruf
Copy link
Member

isuruf commented Jan 12, 2020

Reviewer: Isuru Fernando

@slel
Copy link
Member

slel commented Jan 13, 2020

Changed keywords from none to rpy

@slel

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Jan 20, 2020

Changed branch from u/arojas/support_rpy_3_x to 6e67c65

@vbraun vbraun closed this as completed in e98af51 Jan 20, 2020
@antonio-rojas antonio-rojas mentioned this issue Jan 11, 2020
Closed
@mkoeppe mkoeppe mentioned this issue Aug 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
4 participants
@vbraun @slel @isuruf @antonio-rojas