Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure for fplll #29245

Closed
orlitzky opened this issue Feb 24, 2020 · 21 comments
Closed

spkg-configure for fplll #29245

orlitzky opened this issue Feb 24, 2020 · 21 comments

Comments

@orlitzky
Copy link
Contributor

fplll ships a pkg-config file, is slow to build, and has only one dependency that was already spkg-configurified.

It is packaged for a few distros, so let's use it.

CC: @embray @dimpase @mkoeppe @isuruf @kiwifb

Component: build: configure

Author: Michael Orlitzky

Branch/Commit: 7fc917b

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29245

@orlitzky orlitzky added this to the sage-9.1 milestone Feb 24, 2020
@orlitzky
Copy link
Contributor Author

Author: Michael Orlitzky

@orlitzky
Copy link
Contributor Author

Commit: 34d1c62

@orlitzky

This comment has been minimized.

@orlitzky
Copy link
Contributor Author

Branch: u/mjo/ticket/29245

@orlitzky
Copy link
Contributor Author

New commits:

34d1c62Trac #29245: new spkg-configure.m4 for fplll.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 24, 2020

comment:2

Could you add build/pkgs/fplll/distros/ please (see #29129)?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

e478f11Trac #29245: add "distros" directory with an entry for Gentoo.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2020

Changed commit from 34d1c62 to e478f11

@orlitzky
Copy link
Contributor Author

comment:4

Sure. I'll add the others if people can tell me what to stick in the text files. For example I'm pretty sure you need both the main package and -dev on Debian, but who knows. I'm also pretty sure that someone is going to tell me the pc file is missing somewhere and make me do a header/library search...

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 24, 2020

comment:5

https://repology.org/ has the info you need

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 24, 2020

comment:6

And this all can be tested using tox.

@dimpase
Copy link
Member

dimpase commented Feb 25, 2020

comment:7

on debian one needs libfplll-dev and (probably) fplll-tools

  • the latter is very small, so it doesn't hurt to ask for it be installed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

e8c3867Trac #29245: add Debian package information for fplll.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 25, 2020

Changed commit from e478f11 to e8c3867

@dimpase
Copy link
Member

dimpase commented Feb 27, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Feb 27, 2020

comment:9

Debian fplll package is broken - fplll/pruner/ headers are missing.
So one gets

[fpylll-0.5.1dev]     building 'fpylll.fplll.integer_matrix' extension
[fpylll-0.5.1dev]     creating build/temp.linux-x86_64-2.7/build/src/fpylll/fplll
[fpylll-0.5.1dev]     gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -fPIC -Isrc/fpylll/fplll -I/home/dimpase/sage/local/lib/python2.7/site-packages/cysignals -I/home/dimpase/sage/local/include -I/home/dimpase/sage/local/lib/python2.7/site-packages/numpy/core/include -I/home/dimpase/sage/local/include/python2.7 -c build/src/fpylll/fplll/integer_matrix.cpp -o build/temp.linux-x86_64-2.7/build/src/fpylll/fplll/integer_matrix.o -std=c++11
[fpylll-0.5.1dev]     build/src/fpylll/fplll/integer_matrix.cpp:698:10: fatal error: fplll/pruner/pruner.h: No such file or directory
[fpylll-0.5.1dev]      #include "fplll/pruner/pruner.h"
[fpylll-0.5.1dev]               ^~~~~~~~~~~~~~~~~~~~~~~
[fpylll-0.5.1dev]     compilation terminated.
[fpylll-0.5.1dev]     error: command 'gcc' failed with exit status 1

I propose to include a check for this header in the macro.

@dimpase
Copy link
Member

dimpase commented Feb 27, 2020

comment:10

In fact, fplll-5.2.1 does not have that header, they only appear in fplll-5.3

so, just updating the minimal version will do.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 27, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

7fc917bTrac #29245: increase minimum version of fplll to 5.3.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 27, 2020

Changed commit from e8c3867 to 7fc917b

@orlitzky
Copy link
Contributor Author

comment:12

Replying to @dimpase:

In fact, fplll-5.2.1 does not have that header, they only appear in fplll-5.3

so, just updating the minimal version will do.

Thanks, fixed.

@vbraun
Copy link
Member

vbraun commented Mar 3, 2020

Changed branch from u/mjo/ticket/29245 to 7fc917b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants