Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete scripts from src/bin/ #29383

Closed
mkoeppe opened this issue Mar 20, 2020 · 16 comments
Closed

Remove obsolete scripts from src/bin/ #29383

mkoeppe opened this issue Mar 20, 2020 · 16 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 20, 2020

(Part of #21559.)

CC: @jhpalmieri @dimpase @orlitzky

Component: scripts

Author: Matthias Koeppe

Branch/Commit: f7f34ff

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29383

@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 20, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

New commits:

55430bddelete src/bin/sage-README-osx.txt
6fe5012Remove obsolete script sage-pkg (creates old-style spkg archives)
f7f34ffsrc/bin/sage-unzip: Remove (unused script)

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

Commit: f7f34ff

@dimpase
Copy link
Member

dimpase commented Mar 21, 2020

comment:3

remind me, what's the new way to make user packages for Sage?

@jhpalmieri
Copy link
Member

comment:4

Create the appropriate subdirectory of build/pkgs and populate with checksums.ini, etc.

@jhpalmieri
Copy link
Member

comment:5

But there is no non-deprecated way for someone to create a standalone package which is not part of Sage, I think.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 21, 2020

comment:6

That's right

@jhpalmieri
Copy link
Member

comment:7

It works for me. Is it okay to remove the only way to create standalone user packages, even if it is deprecated? It's not even documented anywhere. I say we merge this. Or do we need to ask on sage-devel?

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 21, 2020

comment:8

The discussion on sage-devel happened already, leading to the deprecatIon.

@dimpase
Copy link
Member

dimpase commented Mar 21, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 21, 2020

comment:9

ok - I assume you checked that this is not in docs any more, either.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 21, 2020

comment:10

Thanks!

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 25, 2020

comment:11

Replying to @dimpase:

ok - I assume you checked that this is not in docs any more, either.

Removing the chapter where it appears in #29289

@jhpalmieri
Copy link
Member

comment:12

Replying to @mkoeppe:

Replying to @dimpase:

ok - I assume you checked that this is not in docs any more, either.

Removing the chapter where it appears in #29289

Or maybe #29406?

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 25, 2020

comment:13

Replying to @jhpalmieri:

Replying to @mkoeppe:

Replying to @dimpase:

ok - I assume you checked that this is not in docs any more, either.

Removing the chapter where it appears in #29289

Or maybe #29406?

You're right.

@vbraun
Copy link
Member

vbraun commented Mar 25, 2020

Changed branch from u/mkoeppe/remove_obsolete_scripts_from_src_bin_ to f7f34ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants