Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sympy to 1.6 #29730

Closed
mkoeppe opened this issue May 25, 2020 · 16 comments
Closed

Update sympy to 1.6 #29730

mkoeppe opened this issue May 25, 2020 · 16 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 25, 2020

https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6

Related:

CC: @kiwifb @timokau @saraedum @slel @antonio-rojas @videlec @isuruf

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: 1734209

Reviewer: Matthias Koeppe, Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/29730

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 25, 2020
@antonio-rojas
Copy link
Contributor

comment:1

I don't know why I'm not getting most trac emails lately... I missed this and I just opened a duplicate with a patch at #29731 - feel free to use it if you don't have your own branch already.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 26, 2020

comment:2

I don't have a branch.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 26, 2020

New commits:

8a395feUpdate sympy to 1.6

@mkoeppe
Copy link
Member Author

mkoeppe commented May 26, 2020

Commit: 8a395fe

@mkoeppe
Copy link
Member Author

mkoeppe commented May 26, 2020

Branch: u/arojas/update_to_sympy_1_6

@antonio-rojas
Copy link
Contributor

Author: Antonio Rojas

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 14, 2020

Changed branch from u/arojas/update_to_sympy_1_6 to u/mkoeppe/update_to_sympy_1_6

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 14, 2020

Changed branch from u/mkoeppe/update_to_sympy_1_6 to u/arojas/update_to_sympy_1_6

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 14, 2020

comment:6

rebased on 9.2.beta1

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 14, 2020

@isuruf
Copy link
Member

isuruf commented Jun 15, 2020

comment:8

all_classes is private API as far as I know.

How about just if isinstance(expression, sympy.Basic) ?

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 15, 2020

comment:9

Replying to @mkoeppe:

Tests run at https://github.com/mkoeppe/sage/actions/runs/135267093

... looking fine.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

1734209Avoid using sympy private API

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2020

Changed commit from 8a395fe to 1734209

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 18, 2020

Reviewer: Matthias Koeppe, Isuru Fernando

@vbraun
Copy link
Member

vbraun commented Jun 22, 2020

Changed branch from u/arojas/update_to_sympy_1_6 to 1734209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants