Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 5: sage.graphs) #29790

Closed
mkoeppe opened this issue Jun 3, 2020 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 3, 2020

Follow-up from #29706 (which is NOT a dependency).

This ticket takes care of sage.graphs except for sage.graphs.graph_decompositions, which is done in #28925, and OptionalExtensions, which are done in #29720.

CC: @kliem @dcoudert @dimpase

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 5d5803e

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29790

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 3, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

New commits:

55bd7basrc/module_list.py: Move options for Extensions in sage.graphs to distutils directives

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

Commit: 55bd7ba

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2020

Author: Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Jun 4, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jun 4, 2020

comment:4

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

comment:5

Thanks!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2020

comment:6

https://github.com/mkoeppe/sage/runs/747836383

graphs   ] WARNING: autodoc: failed to import module 'planarity' from module 'sage.graphs'; the following exception was raised:
[graphs   ] dlopen(/Users/runner/runners/2.263.0/work/sage/sage/.tox/local-homebrew-macos-standard/local/lib/python3.7/site-packages/sage/graphs/planarity.cpython-37m-darwin.so, 2): Symbol not found: _gp_AddEdge
[graphs   ]   Referenced from: /Users/runner/runners/2.263.0/work/sage/sage/.tox/local-homebrew-macos-standard/local/lib/python3.7/site-packages/sage/graphs/planarity.cpython-37m-darwin.so
[graphs   ]   Expected in: flat namespace

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

5d5803esrc/sage/graphs/planarity.pyx: Add forgotten distutils directive

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2020

Changed commit from 55bd7ba to 5d5803e

@kliem
Copy link
Contributor

kliem commented Jun 8, 2020

comment:9

Should be fine now.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2020

comment:10

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants